Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to modify the font size of the app #1582

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Oct 2, 2023

This option is present in the new "Edit"->"Configuration" dialog. This modifies the font size of both Qt and matplotlib.

When the user modifies the font size in the dialog, most (but not all) widgets in the application are updated immediately. It appears that any widgets with custom style sheets do not get updated. Perhaps some other types of widgets don't get updated either. But restarting the application normally appears to update everything to the new font size.

It would be nice to get all widgets to update immediately when the user modifies the font size. But for now, we can just present a warning that the user should restart the application normally in order to get all widgets to update.

Fixes: #1575

This option is present in the new "Edit"->"Configuration"
dialog. This modifies the font size of both Qt and matplotlib.

When the user modifies the font size in the dialog, most (but not all)
widgets in the application are updated immediately. It appears that
any widgets with custom style sheets do not get updated. Perhaps some
other types of widgets don't get updated either. But restarting the
application normally appears to update everything to the new font
size.

It would be nice to get all widgets to update immediately when the
user modifies the font size. But for now, we can just present a warning
that the user should restart the application normally in order to get
all widgets to update.

Fixes: #1575

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery requested a review from bnmajor October 2, 2023 16:40
Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not a big deal but the default font size seems larger than it used to be - changing it to 9 seemed closer to what it was to me. But that may also be a platform specific thing

@psavery psavery merged commit 8f931d2 into master Oct 3, 2023
9 checks passed
@psavery psavery deleted the change-font branch October 3, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to change the font size of the UI
2 participants